Export: Automatically fetch advanced settings when switching to exporter #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jordwest
added
[Status] Needs Review
| const siteId = state.ui.selectedSiteId; | ||
| return { | ||
| siteId: siteId, | ||
| shouldShowPlaceholders: !advancedSettings( state, siteId ) |
There was a problem hiding this comment.
Very minor thing: Here and in one or two spots later, we're missing a space after the !.
|
This works well for me. I suggested a minor fix, but otherwise, I think we should squash commits as needed and 🚢. |
jordwest
force-pushed
the
add/exporter/auto-fetch-settings
branch
from
ed2c9ee to
f7d774c
Compare
Squashed: Export: Show placeholders while loading options Export: Make existing tests pass Export: Add unit tests for fetchingAdvancedSettings reducer Export: Remove redundant serialize/deserialize
jordwest
force-pushed
the
add/exporter/auto-fetch-settings
branch
from
f7d774c to
ad876ca
Compare
jordwest
removed
the
[Status] Needs Review
jordwest
added a commit
that referenced
this pull request
Feb 9, 2016
…ings Export: Automatically fetch advanced settings when switching to exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR triggers a fetch of the export advanced settings when:
Automated Testing
Browser Testing
EXPORT_ADVANCED_SETTINGS_FETCHandEXPORT_ADVANCED_SETTINGS_RECEIVEactions have fired in the Redux developer console:EXPORT_ADVANCED_SETTINGS_FETCHaction fire - this is to refresh the settings in the background to ensure they are up to date.